Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: tools/perf/benchmarks/session_restore.py

Issue 1126443002: Move user_story.user_story_set to story.story_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/repaint.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/session_restore.py
diff --git a/tools/perf/benchmarks/session_restore.py b/tools/perf/benchmarks/session_restore.py
index 541bd3aea8f5a05f927e455779392731914cd83c..32ecbdf46abd9995f860fb8b95ed07d419df28d2 100644
--- a/tools/perf/benchmarks/session_restore.py
+++ b/tools/perf/benchmarks/session_restore.py
@@ -56,17 +56,17 @@ class _SessionRestoreTypical25(perf_benchmark.PerfBenchmark):
def ValueCanBeAddedPredicate(cls, _, is_first_result):
return cls.tag == 'cold' or not is_first_result
- def CreateUserStorySet(self, _):
- """Return a user story set that only has the first user story.
+ def CreateStorySet(self, _):
+ """Return a story set that only has the first user story.
The session restore measurement skips the navigation step and
only tests session restore by having the browser start-up.
The first user story is used to get WPR set up and hold results.
"""
- user_story_set = self.page_set()
- for user_story in user_story_set.user_stories[1:]:
- user_story_set.RemoveUserStory(user_story)
- return user_story_set
+ story_set = self.page_set()
+ for user_story in story_set.user_stories[1:]:
+ story_set.RemoveUserStory(user_story)
+ return story_set
def CreatePageTest(self, options):
is_cold = (self.tag == 'cold')
« no previous file with comments | « tools/perf/benchmarks/repaint.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698