Issue 112643003: Revert of Show speech button for x-webkit-speech only if the field is editable and focused/hovered.

Issue 112643003: Revert of Show speech button for x-webkit-speech only if the field is editable and focused/hovered. (Closed)

Created:
7 years ago by Justin Novosad

Modified:
7 years ago

Reviewers:
keishi, tkent

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/100793006/ Reason for revert: Tests InputTagSpeechBrowserTest.GrammarAttribute and InputTagSpeechBrowserTest.TestBasicRecognition in the range 163857:163860. This CL is the most probable cause. TBR=keishi@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -33 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/speech/input-appearance-searchandspeech.html	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/speech/input-appearance-speechbutton.html	View	3 chunks	+2 lines, -13 lines	0 comments	Download
M	LayoutTests/fast/speech/speech-bidi-rendering.html	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	Source/core/css/html.css	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

Created Revert of Show speech button for x-webkit-speech only if the field is editable and ...

7 years ago (2013-12-13 16:45:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/112643003/1

7 years ago (2013-12-13 16:46:30 UTC) #2

commit-bot: I haz the power

Failed to apply patch for LayoutTests/fast/speech/speech-bidi-rendering.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years ago (2013-12-13 16:46:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/112643003/1

7 years ago (2013-12-13 17:52:28 UTC) #4

commit-bot: I haz the power

Failed to apply patch for LayoutTests/fast/speech/speech-bidi-rendering.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years ago (2013-12-13 17:52:33 UTC) #5

Justin Novosad

On 2013/12/13 16:46:33, I haz the power (commit-bot) wrote: > Failed to apply patch for ...

7 years ago (2013-12-13 18:15:59 UTC) #6

tkent

Sorry for the trouble. I looked at the test, and we just need to update ...

7 years ago (2013-12-13 18:19:03 UTC) #7

Justin Novosad

7 years ago (2013-12-13 18:20:55 UTC) #8

On 2013/12/13 18:15:59, junov wrote:
> On 2013/12/13 16:46:33, I haz the power (commit-bot) wrote:
> > Failed to apply patch for
LayoutTests/fast/speech/speech-bidi-rendering.html:
> > While running patch -p1 --forward --force --no-backup-if-mismatch;
> >   patching file LayoutTests/fast/speech/speech-bidi-rendering.html
> >   patch unexpectedly ends in middle of line
> > 
> > Patch:       LayoutTests/fast/speech/speech-bidi-rendering.html
> > Index: LayoutTests/fast/speech/speech-bidi-rendering.html
> > diff --git a/LayoutTests/fast/speech/speech-bidi-rendering.html
> > b/LayoutTests/fast/speech/speech-bidi-rendering.html
> > index
> >
>
d59ee3e8c43f952f486529b0a85b5a0d1d2069a3..9d46fc6fc4c2dfea43bc8a01d893544eef8aee6c
> > 100644
> > --- a/LayoutTests/fast/speech/speech-bidi-rendering.html
> > +++ b/LayoutTests/fast/speech/speech-bidi-rendering.html
> > @@ -1,11 +1,6 @@
> >  <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> >  <html>
> >  <body>
> > -<style>
> > -input::-webkit-input-speech-button {
> > -    opacity: 1;
> > -}
> > -</style>
> >  <p>
> >    This test verifies that the speech input control is rendered correctly
for
> >  dir=rtl/ltr.
> > @@ -32,4 +27,4 @@
> >    document.getElementById("speechInputLTRtoRTL").dir = 'rtl';
> >  </script>
> >  </body>
> > -</html>
> > +</html>
> 
> This is a bogus conflict. Will revert by hand

Retrying using drover:
https://codereview.chromium.org/111443004

Expand Messages | Collapse Messages