Issue 111443004: Revert 163860 "Show speech button for x-webkit-speech only if th..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111443004: Revert 163860 "Show speech button for x-webkit-speech only if th..." (Closed)

Created:
7 years ago by Justin Novosad

Modified:
7 years ago

Reviewers:
tkent

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 163860 "Show speech button for x-webkit-speech only if th..." Reason for revert: Tests InputTagSpeechBrowserTest.GrammarAttribute and InputTagSpeechBrowserTest.TestBasicRecognition in the range 163857:163860. This CL is the most probable cause. > Show speech button for x-webkit-speech only if the field is editable and focused/hovered. > > BUG=325496 > > Review URL: https://codereview.chromium.org/100793006 TBR=tkent@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+3 lines, -33 lines)			Patch
trunk/LayoutTests/TestExpectations	View	1 chunk	+0 lines, -2 lines	0 comments	Download
trunk/LayoutTests/fast/speech/input-appearance-searchandspeech.html	View	1 chunk	+0 lines, -5 lines	0 comments	Download
trunk/LayoutTests/fast/speech/input-appearance-speechbutton.html	View	3 chunks	+2 lines, -13 lines	0 comments	Download
trunk/LayoutTests/fast/speech/speech-bidi-rendering.html	View	2 chunks	+1 line, -6 lines	0 comments	Download
trunk/Source/core/css/html.css	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

7 years ago (2013-12-13 18:24:00 UTC) #5

On 2013/12/13 18:17:48, junov wrote:

Drover failed.
New try: https://codereview.chromium.org/115353004

Expand Messages | Collapse Messages