Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1126423006: Don't do discards when on Adreno4xx due to driver bug. (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't do discards when on Adreno4xx due to driver bug. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9250d24de6bb7d26b462fb573f66431948496127

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
egdaniel
5 years, 7 months ago (2015-05-18 18:44:57 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1126423006/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1126423006/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode223 src/gpu/gl/GrGLCaps.cpp:223: // We are blacklisting this exxtension for now ...
5 years, 7 months ago (2015-05-18 19:02:05 UTC) #3
egdaniel
https://codereview.chromium.org/1126423006/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1126423006/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode223 src/gpu/gl/GrGLCaps.cpp:223: // We are blacklisting this exxtension for now on ...
5 years, 7 months ago (2015-05-18 19:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126423006/40001
5 years, 7 months ago (2015-05-18 19:11:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126423006/40001
5 years, 7 months ago (2015-05-18 19:23:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126423006/40001
5 years, 7 months ago (2015-05-18 19:41:26 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 20:04:33 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9250d24de6bb7d26b462fb573f66431948496127

Powered by Google App Engine
This is Rietveld 408576698