plugin: Don't warn about inline virtual methods from system macros; whitelist two non-system macros.

plugin: Don't warn about inline virtual methods from system macros; whitelist two non-system macros.

Even though CR_BEGIN_MSG_MAP_EX and BEGIN_SAFE_MSG_MAP_EX are from chromium
code, they are interface-compatible with the system macro BEGIN_MSG_MAP_EX
and so we can't fix the style plugin warnings about them.  So whitelist these
two macros.

BUG=484721
Committed: https://crrev.com/282351bf126ca09cb5c3b9bf4663a52dc7f355e3
Cr-Commit-Position: refs/heads/master@{#328880}

[Nico, 2015-05-07 22:41:27]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org, hans@chromium.org

[dcheng, 2015-05-07 22:43:14]

lgtm

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
File tools/clang/plugins/FindBadConstructsConsumer.cpp (right):

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
tools/clang/plugins/FindBadConstructsConsumer.cpp:529:
emitWarning(cs->getLBracLoc(),
Nit: loc?

[scottmg, 2015-05-07 22:43:30]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-05-07 22:43:31]

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
File tools/clang/plugins/FindBadConstructsConsumer.cpp (right):

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
tools/clang/plugins/FindBadConstructsConsumer.cpp:514: // we can't easily fix
them, so explicilty whitelist them here.
"explicitly"

[Nico, 2015-05-07 22:50:31]

Thanks!

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
File tools/clang/plugins/FindBadConstructsConsumer.cpp (right):

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
tools/clang/plugins/FindBadConstructsConsumer.cpp:514: // we can't easily fix
them, so explicilty whitelist them here.
On 2015/05/07 22:43:30, scottmg wrote:
> "explicitly"

Done.

https://codereview.chromium.org/1126413004/diff/20001/tools/clang/plugins/Fin...
tools/clang/plugins/FindBadConstructsConsumer.cpp:529:
emitWarning(cs->getLBracLoc(),
On 2015/05/07 22:43:14, dcheng wrote:
> Nit: loc?

Done.

[Nico, 2015-05-07 22:50:42]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-05-07 22:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1126413004/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2015-05-07 22:52:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126413004/40001

[commit-bot: I haz the power, 2015-05-07 23:43:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-07 23:45:29]

Patchset 3 (id:??) landed as
https://crrev.com/282351bf126ca09cb5c3b9bf4663a52dc7f355e3
Cr-Commit-Position: refs/heads/master@{#328880}