Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: tools/clang/plugins/tests/virtual_bodies.txt

Issue 1126413004: plugin: Don't warn about inline virtual methods from system macros; whitelist two non-system macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from virtual_bodies.cpp:5: 1 In file included from virtual_bodies.cpp:5:
2 ./virtual_bodies.h:17:36: warning: [chromium-style] virtual methods with non-emp ty bodies shouldn't be declared inline. 2 ./virtual_bodies.h:23:36: warning: [chromium-style] virtual methods with non-emp ty bodies shouldn't be declared inline.
3 virtual bool ComplainAboutThis() { return true; } 3 virtual bool ComplainAboutThis() { return true; }
4 ^ 4 ^
5 1 warning generated. 5 1 warning generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698