Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1126363003: Remove dart2dart support from testing scripts and status files (Closed)

Created:
5 years, 7 months ago by ricow1
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove dart2dart support from testing scripts and status files I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep) R=kustermann@google.com, floitsch@google.com, kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45588

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -404 lines) Patch
M dart.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/pub.status View 1 chunk +1 line, -1 line 0 comments Download
D tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -122 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 6 chunks +4 lines, -26 lines 0 comments Download
M tests/isolate/isolate.status View 1 3 chunks +2 lines, -13 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -21 lines 0 comments Download
M tests/language/language_dart2js.status View 1 3 chunks +2 lines, -80 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +0 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/bots/bot.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/docs/docs.status View 1 chunk +1 line, -1 line 0 comments Download
M tools/status_clean.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/co19_test_config.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 3 chunks +1 line, -54 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/testing/dart/test_options.dart View 3 chunks +1 line, -5 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 7 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ricow1
5 years, 7 months ago (2015-05-07 09:13:24 UTC) #1
ricow1
+kustermann since the two others are not around
5 years, 7 months ago (2015-05-07 10:47:56 UTC) #3
kustermann
LGTM :) https://codereview.chromium.org/1126363003/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://codereview.chromium.org/1126363003/diff/1/tests/isolate/isolate.status#newcode74 tests/isolate/isolate.status:74: [ ($compiler == none) && ($runtime == ...
5 years, 7 months ago (2015-05-07 11:23:26 UTC) #4
ricow1
thanks Martin
5 years, 7 months ago (2015-05-07 11:27:40 UTC) #5
ricow1
5 years, 7 months ago (2015-05-07 11:30:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698