Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1126363003: Remove dart2dart support from testing scripts and status files (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/co19_test_config.dart ('k') | tools/testing/dart/status_reporter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 3681bae271b6983a2a2351817f7eb25976e15f8d..e2b0d18754c8ecfda12b7813d0e558d7293cc88c 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -77,10 +77,6 @@ abstract class CompilerConfiguration {
isHostChecked: isHostChecked, useCps: useCps, useSdk: useSdk,
isCsp: isCsp, extraDart2jsOptions:
TestUtils.getExtraOptions(configuration, 'dart2js_options'));
- case 'dart2dart':
- return new Dart2dartCompilerConfiguration(
- isDebug: isDebug, isChecked: isChecked,
- isHostChecked: isHostChecked, useSdk: useSdk);
case 'none':
return new NoneCompilerConfiguration(
isDebug: isDebug, isChecked: isChecked,
@@ -166,8 +162,7 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
}
}
-/// Common configuration for dart2js-based tools, such as, dart2js and
-/// dart2dart.
+/// Common configuration for dart2js-based tools, such as, dart2js
class Dart2xCompilerConfiguration extends CompilerConfiguration {
final String moniker;
static Map<String, List<Uri>> _bootstrapDependenciesCache =
@@ -290,54 +285,6 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
}
}
-/// Configuration for dart2dart compiler.
-class Dart2dartCompilerConfiguration extends Dart2xCompilerConfiguration {
- Dart2dartCompilerConfiguration({
- bool isDebug,
- bool isChecked,
- bool isHostChecked,
- bool useSdk})
- : super(
- 'dart2dart',
- isDebug: isDebug, isChecked: isChecked,
- isHostChecked: isHostChecked, useSdk: useSdk);
-
- CommandArtifact computeCompilationArtifact(
- String buildDir,
- String tempDir,
- CommandBuilder commandBuilder,
- List arguments,
- Map<String, String> environmentOverrides) {
- String outputFileName = '$tempDir/out.dart';
- arguments = new List.from(arguments)..add('--output-type=dart');
- return new CommandArtifact(
- <Command>[
- this.computeCompilationCommand(
- outputFileName,
- buildDir,
- CommandBuilder.instance,
- arguments,
- environmentOverrides)],
- outputFileName,
- 'application/dart');
- }
-
- List<String> computeRuntimeArguments(
- RuntimeConfiguration runtimeConfiguration,
- String buildDir,
- TestInformation info,
- List<String> vmOptions,
- List<String> sharedOptions,
- List<String> originalArguments,
- CommandArtifact artifact) {
- // TODO(antonm): support checked.
- return <String>[]
- ..addAll(vmOptions)
- ..add('--ignore-unrecognized-flags')
- ..add(artifact.filename);
- }
-}
-
/// Common configuration for analyzer-based tools, such as, dartanalyzer.
class AnalyzerCompilerConfiguration extends CompilerConfiguration {
final String moniker;
« no previous file with comments | « tools/testing/dart/co19_test_config.dart ('k') | tools/testing/dart/status_reporter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698