Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/browser/ui/browser.cc

Issue 112623003: Remove toolbar from extension windows in streamlined hosted apps mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index e56a0b649a7becb90cd34a10932025b0498bc5f9..04a6f0c3d43def8e5b57f3d19dc41fcfca330878 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -289,6 +289,7 @@ Browser::CreateParams Browser::CreateParams::CreateForDevTools(
chrome::HostDesktopType host_desktop_type) {
CreateParams params(TYPE_POPUP, profile, host_desktop_type);
params.app_name = DevToolsWindow::kDevToolsApp;
+ params.app_type = APP_TYPE_CHILD;
sky 2013/12/12 17:03:35 Why are you changing the app_type? I have to admit
calamity 2013/12/13 02:02:54 My bad. Done.
return params;
}
@@ -2170,8 +2171,9 @@ bool Browser::SupportsWindowFeatureImpl(WindowFeature feature,
if (is_type_tabbed())
features |= FEATURE_TOOLBAR;
- if (!is_app() || CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableStreamlinedHostedApps))
+ if (!is_app() || (app_type() == APP_TYPE_HOST &&
sky 2013/12/12 17:03:35 Wouldn't it be better to special case devtools rat
calamity 2013/12/13 02:02:54 Done.
+ CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableStreamlinedHostedApps)))
features |= FEATURE_LOCATIONBAR;
}
return !!(features & feature);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698