Remove toolbar from extension windows in streamlined hosted apps mode.

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 271 matching lines @@
 
   return params;
 }
 
 // static
 Browser::CreateParams Browser::CreateParams::CreateForDevTools(
     Profile* profile,
     chrome::HostDesktopType host_desktop_type) {
   CreateParams params(TYPE_POPUP, profile, host_desktop_type);
   params.app_name = DevToolsWindow::kDevToolsApp;
+  params.app_type = APP_TYPE_CHILD;

[sky, 2013/12/12 17:03:35]

Why are you changing the app_type? I have to admit I don't understand the
subtleties between the two, but APP_TYPE_HOST seems to better match dev tools.

[calamity, 2013/12/13 02:02:54]

My bad. Done.

   return params;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Browser, InterstitialObserver:
 
 class Browser::InterstitialObserver : public content::WebContentsObserver {
  public:
   InterstitialObserver(Browser* browser, content::WebContents* web_contents)
       : WebContentsObserver(web_contents),
@@ skipping 1861 matching lines @@
   if (!hide_ui_for_fullscreen) {
     if (!is_type_tabbed())
       features |= FEATURE_TITLEBAR;
 
     if (is_type_tabbed())
       features |= FEATURE_TABSTRIP;
 
     if (is_type_tabbed())
       features |= FEATURE_TOOLBAR;
 
-    if (!is_app() || CommandLine::ForCurrentProcess()->HasSwitch(
-                         switches::kEnableStreamlinedHostedApps))
+    if (!is_app() || (app_type() == APP_TYPE_HOST &&

[sky, 2013/12/12 17:03:35]

Wouldn't it be better to special case devtools rather than look at app_type?

[calamity, 2013/12/13 02:02:54]

Done.

+                      CommandLine::ForCurrentProcess()->HasSwitch(
+                          switches::kEnableStreamlinedHostedApps)))
       features |= FEATURE_LOCATIONBAR;
   }
   return !!(features & feature);
 }
 
 void Browser::UpdateBookmarkBarState(BookmarkBarStateChangeReason reason) {
   BookmarkBar::State state;
   // The bookmark bar is hidden in fullscreen mode, unless on the new tab page.
   if (browser_defaults::bookmarks_enabled &&
       profile_->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar) &&
@@ skipping 113 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }