Remove toolbar from extension windows in streamlined hosted apps mode.

Remove toolbar from extension windows in streamlined hosted apps mode.

Previously, extension windows would have the chrome toolbar. This CL
prevents child app windows from getting a toolbar in streamlined
hosted apps mode which fixes this issue.

BUG=318607
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243757

[calamity, 2013-12-12 06:47:54]

+sky for chrome/browser/ui/ OWNERS

[sky, 2013-12-12 17:03:35]

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:292: params.app_type = APP_TYPE_CHILD;
Why are you changing the app_type? I have to admit I don't understand the
subtleties between the two, but APP_TYPE_HOST seems to better match dev tools.

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:2174: if (!is_app() || (app_type() == APP_TYPE_HOST
&&
Wouldn't it be better to special case devtools rather than look at app_type?

[calamity, 2013-12-13 02:02:53]

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:292: params.app_type = APP_TYPE_CHILD;
On 2013/12/12 17:03:35, sky wrote:
> Why are you changing the app_type? I have to admit I don't understand the
> subtleties between the two, but APP_TYPE_HOST seems to better match dev tools.

My bad. Done.

https://codereview.chromium.org/112623003/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:2174: if (!is_app() || (app_type() == APP_TYPE_HOST
&&
On 2013/12/12 17:03:35, sky wrote:
> Wouldn't it be better to special case devtools rather than look at app_type?

Done.

[calamity, 2014-01-07 04:44:18]

Ping. Please take another look when you have time, thanks.

[sky, 2014-01-07 15:58:20]

LGTM

[commit-bot: I haz the power, 2014-01-08 03:25:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/112623003/80001

[commit-bot: I haz the power, 2014-01-08 03:46:58]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-09 01:50:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/112623003/350001

[commit-bot: I haz the power, 2014-01-09 04:15:42]

Change committed as 243757