Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1126173003: Fix Get* calls in GPU Command buffer. (Closed)

Created:
5 years, 7 months ago by Zhenyao Mo
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), bajones, vmiura, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@tex
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Get* calls in GPU Command buffer. This CL should make conformance2/state/gl-get-calls.html mostly passing except for COPY_READ_BUFFER_BINDING/COPY_WRITE_BUFFER_BINDING. BUG=429053 TEST=conformance2/state/gl-get-calls.html R=piman@chromium.org Committed: https://crrev.com/0e679b21d216c1bee75511d50f2ecc6fedabf01a Cr-Commit-Position: refs/heads/master@{#330457}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -20 lines) Patch
M gpu/blink/webgraphicscontext3d_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 6 chunks +37 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 3 chunks +8 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +12 lines, -7 lines 1 comment Download
M gpu/ipc/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Zhenyao Mo
piman: PTAL others: FYI (feel free to review)
5 years, 7 months ago (2015-05-18 22:23:30 UTC) #1
piman
LGTM, but see question. https://codereview.chromium.org/1126173003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1126173003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3008 gpu/command_buffer/service/gles2_cmd_decoder.cc:3008: caps.max_server_wait_timeout = 0; Is 0 ...
5 years, 7 months ago (2015-05-19 00:13:41 UTC) #2
Zhenyao Mo
On 2015/05/19 00:13:41, piman (Very slow to review) wrote: > LGTM, but see question. > ...
5 years, 7 months ago (2015-05-19 00:20:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126173003/1
5 years, 7 months ago (2015-05-19 00:21:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 00:26:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:27:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e679b21d216c1bee75511d50f2ecc6fedabf01a
Cr-Commit-Position: refs/heads/master@{#330457}

Powered by Google App Engine
This is Rietveld 408576698