Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1126043007: Adding immediate mode draw target for debug (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adding immediate mode draw target for debug BUG=skia: Committed: https://skia.googlesource.com/skia/+/bb87b2104b5fe5f61c88756af6e25fbd3f5ca773

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -2 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
A src/gpu/GrImmediateDrawTarget.h View 1 chunk +91 lines, -0 lines 0 comments Download
A src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +106 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
not totally sure how to handle the drawID / reset stuff. Otherwise ptal.
5 years, 7 months ago (2015-05-18 21:20:46 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-19 21:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126043007/20001
5 years, 7 months ago (2015-05-19 21:20:08 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:28:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bb87b2104b5fe5f61c88756af6e25fbd3f5ca773

Powered by Google App Engine
This is Rietveld 408576698