Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1126013005: Enable large file support on linux/chromeos (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, vapier
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable large file support on linux/chromeos Original CL (https://codereview.chromium.org/1059613002) works only debug build. Instead of defining two places, I think this is better. BUG=471407 Committed: https://crrev.com/33c594d96130002bc76c844d903ca5ab5a82e22b Cr-Commit-Position: refs/heads/master@{#330043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/common.gypi View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oshima
5 years, 7 months ago (2015-05-15 01:12:13 UTC) #3
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-15 03:20:03 UTC) #4
vapier
lgtm
5 years, 7 months ago (2015-05-15 03:45:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126013005/1
5 years, 7 months ago (2015-05-15 03:55:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 04:57:22 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 04:58:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33c594d96130002bc76c844d903ca5ab5a82e22b
Cr-Commit-Position: refs/heads/master@{#330043}

Powered by Google App Engine
This is Rietveld 408576698