Enable large file support

Enable large file support

ChromeOS may use 32bit userspace on 64bit kernel. Make sure all 64bits are used when acessing file.

note: _FILE_OFFSET_BITS is already set to 64 on posix.

BUG=471407
Committed: https://crrev.com/f33a81c14818d8cdde53e3dc34f1b1344a4583f3
Cr-Commit-Position: refs/heads/master@{#323688}

[oshima, 2015-04-02 22:04:07]

oshima@chromium.org changed reviewers:
+ dpranke@chromium.org, vapier@chromium.org

[vapier, 2015-04-02 22:10:53]

there's no reason for this to be CrOS specific.  this applies to all Linux/glibc
systems.

[oshima, 2015-04-02 22:59:41]

On 2015/04/02 22:10:53, vapier wrote:
> there's no reason for this to be CrOS specific.  this applies to all
Linux/glibc
> systems.

sure, done.

[Dirk Pranke, 2015-04-02 23:01:17]

presumably we should add this to the GN configs as well?

[vapier, 2015-04-02 23:18:45]

if tests pass, i can't think of a reason to not lgtm

[vapier, 2015-04-02 23:18:59]

ugh, lgtm

[oshima, 2015-04-02 23:20:30]

On 2015/04/02 23:18:59, vapier wrote:
> ugh, lgtm

Looks like this broke android build. Let me exclude android.

[oshima, 2015-04-02 23:33:59]

Uploaded new patch. PTAL

On 2015/04/02 23:01:17, Dirk Pranke wrote:
> presumably we should add this to the GN configs as well?

Isn't build/config/compiler/BUILD.gn enough?

[vapier, 2015-04-02 23:57:33]

yeah, android uses bionic which i can see handling LFS differently

lgtm

[Dirk Pranke, 2015-04-03 00:09:25]

oh, sorry, somehow I'm blind and didn't see the second file :(.

lgtm.

[oshima, 2015-04-03 01:10:13]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-04-03 04:44:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1059613002/60001

[commit-bot: I haz the power, 2015-04-03 08:02:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-03 20:35:19]

Patchset 4 (id:??) landed as
https://crrev.com/f33a81c14818d8cdde53e3dc34f1b1344a4583f3
Cr-Commit-Position: refs/heads/master@{#323688}

[brettw, 2015-05-11 21:03:53]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-05-11 21:03:53]

This is not right. The place you changed is in the "Debug_Base" configuration.
This will apply these flags only to the debug build in GYP. In the GN build
these are applied correctly. I'll reopen the bug.