Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1125913002: Revert of [mojo] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
anujsharma, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (patchset #3 id:40001 of https://codereview.chromium.org/1118473002/) Reason for revert: breaks compilation on win gn https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6922 Original issue's description: > Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in mojo module. > > MessageLoopProxy is deprecated. > This basically does a search and replace: > > MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). > > BUG=391045 > > Committed: https://crrev.com/332a1b2b1d5635199d5ed453f5f9586b2e030b64 > Cr-Commit-Position: refs/heads/master@{#328311} TBR=sky@chromium.org,anujk.sharma@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=391045 Committed: https://crrev.com/b77bd75920b697f0c1b06e74b760d308bb863e42 Cr-Commit-Position: refs/heads/master@{#328314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M mojo/application/content_handler_factory.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M mojo/common/handle_watcher.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/runner/child_process.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/runner/in_process_native_runner.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of [mojo] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle
5 years, 7 months ago (2015-05-05 12:15:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125913002/1
5 years, 7 months ago (2015-05-05 12:15:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 12:16:06 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 12:17:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b77bd75920b697f0c1b06e74b760d308bb863e42
Cr-Commit-Position: refs/heads/master@{#328314}

Powered by Google App Engine
This is Rietveld 408576698