Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: mojo/common/handle_watcher.cc

Issue 1125913002: Revert of [mojo] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | mojo/runner/child_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/handle_watcher.cc
diff --git a/mojo/common/handle_watcher.cc b/mojo/common/handle_watcher.cc
index 8d20b1680da372d1a52b5afbb24f5d80ca64a4e2..79cdcdb616b7e8cc5c1b69603b945b52f06ced65 100644
--- a/mojo/common/handle_watcher.cc
+++ b/mojo/common/handle_watcher.cc
@@ -14,10 +14,9 @@
#include "base/memory/singleton.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
-#include "base/single_thread_task_runner.h"
+#include "base/message_loop/message_loop_proxy.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
-#include "base/thread_task_runner_handle.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "base/time/time.h"
@@ -44,14 +43,14 @@
WatchData()
: id(0),
handle_signals(MOJO_HANDLE_SIGNAL_NONE),
- task_runner(NULL) {}
+ message_loop(NULL) {}
WatcherID id;
Handle handle;
MojoHandleSignals handle_signals;
base::TimeTicks deadline;
base::Callback<void(MojoResult)> callback;
- scoped_refptr<base::SingleThreadTaskRunner> task_runner;
+ scoped_refptr<base::MessageLoopProxy> message_loop;
};
// WatcherBackend --------------------------------------------------------------
@@ -125,7 +124,7 @@
handle_to_data_.erase(handle);
MessagePumpMojo::current()->RemoveHandler(handle);
- data.task_runner->PostTask(FROM_HERE, base::Bind(data.callback, result));
+ data.message_loop->PostTask(FROM_HERE, base::Bind(data.callback, result));
}
bool WatcherBackend::GetMojoHandleByWatcherID(WatcherID watcher_id,
@@ -239,9 +238,9 @@
request_data.start_data.callback = callback;
request_data.start_data.handle_signals = handle_signals;
request_data.start_data.deadline = deadline;
- request_data.start_data.task_runner = base::ThreadTaskRunnerHandle::Get();
- DCHECK_NE(static_cast<base::SingleThreadTaskRunner*>(NULL),
- request_data.start_data.task_runner.get());
+ request_data.start_data.message_loop = base::MessageLoopProxy::current();
+ DCHECK_NE(static_cast<base::MessageLoopProxy*>(NULL),
+ request_data.start_data.message_loop.get());
AddRequest(request_data);
return request_data.start_data.id;
}
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | mojo/runner/child_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698