src/mips64/code-stubs-mips64.cc - Issue 1125783002: [es6] When comparing two symbols we may need to throw a TypeError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/code-stubs-mips64.cc

Issue 1125783002: [es6] When comparing two symbols we may need to throw a TypeError (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/code-stubs-mips64.cc

diff --git a/src/mips64/code-stubs-mips64.cc b/src/mips64/code-stubs-mips64.cc

index 9cfef7d8d627b5b47c359ebddf5e29df9de01a6f..c93c96d65b8fa2b79794bbcd25fcc35280956069 100644

--- a/src/mips64/code-stubs-mips64.cc

+++ b/src/mips64/code-stubs-mips64.cc

@@ -290,6 +290,8 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm,

if (cc == less || cc == greater) {

__ GetObjectType(a0, t0, t0);

__ Branch(slow, greater, t0, Operand(FIRST_SPEC_OBJECT_TYPE));

+ __ GetObjectType(a0, t0, t0);

+ __ Branch(slow, eq, t0, Operand(SYMBOL_TYPE));

} else {

__ GetObjectType(a0, t0, t0);

__ Branch(&heap_number, eq, t0, Operand(HEAP_NUMBER_TYPE));

« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/ppc/code-stubs-ppc.cc » ('j') | no next file with comments »