Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1125683002: Avoid nearly identical toImplArray() and toImplHeapArray() (Closed)

Created:
5 years, 7 months ago by Jens Widell
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid nearly identical toImplArray() and toImplHeapArray() The only difference is the vector type, which can be made the template argument. The value type is available as VectorType::ValueType. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -90 lines) Patch
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 2 chunks +18 lines, -49 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/cachestorage/CacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL I saw https://codereview.chromium.org/1112363003/ and thought it was a bit unfortunate to duplicate toImplArray() only ...
5 years, 7 months ago (2015-05-04 09:57:27 UTC) #2
haraken
Thanks for the clean-up! LGTM.
5 years, 7 months ago (2015-05-04 14:09:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125683002/1
5 years, 7 months ago (2015-05-04 14:11:09 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 15:46:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194867

Powered by Google App Engine
This is Rietveld 408576698