Avoid nearly identical toImplArray() and toImplHeapArray()

Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 734 matching lines @@
         } else {
             exceptionState.throwTypeError("Invalid Array element type");
             return HeapVector<Member<T>>();
         }
     }
     return result;
 }
 
 // Converts a JavaScript value to an array as per the Web IDL specification:
 // http://www.w3.org/TR/2012/CR-WebIDL-20120419/#es-array
-template <typename T>
-Vector<T> toImplArray(v8::Local<v8::Value> value, int argumentIndex, v8::Isolate* isolate, ExceptionState& exceptionState)
+template <typename VectorType>
+VectorType toImplArray(v8::Local<v8::Value> value, int argumentIndex, v8::Isolate* isolate, ExceptionState& exceptionState)
 {
+    typedef typename VectorType::ValueType ValueType;
+    typedef NativeValueTraits<ValueType> TraitsType;
+
     uint32_t length = 0;
     if (value->IsArray()) {
         length = v8::Local<v8::Array>::Cast(value)->Length();
     } else if (!toV8Sequence(value, length, isolate, exceptionState)) {
         if (!exceptionState.hadException())
             exceptionState.throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex));
-        return Vector<T>();
+        return VectorType();
     }
 
-    if (length > WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(T)) {
+    if (length > WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(ValueType)) {
         exceptionState.throwTypeError("Array length exceeds supported limit.");
-        return Vector<T>();
+        return VectorType();
     }
 
-    Vector<T> result;
+    VectorType result;
     result.reserveInitialCapacity(length);
-    typedef NativeValueTraits<T> TraitsType;
     v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
     v8::TryCatch block;
     for (uint32_t i = 0; i < length; ++i) {
         v8::Local<v8::Value> element;
         if (!v8Call(object->Get(isolate->GetCurrentContext(), i), element, block)) {
             exceptionState.rethrowV8Exception(block.Exception());
-            return Vector<T>();
+            return VectorType();
         }
         result.uncheckedAppend(TraitsType::nativeValue(isolate, element, exceptionState));
         if (exceptionState.hadException())
-            return Vector<T>();
+            return VectorType();
     }
     return result;
 }
 
-template <typename T>
-HeapVector<T> toImplHeapArray(v8::Local<v8::Value> value, int argumentIndex, v8::Isolate* isolate, ExceptionState& exceptionState)
+template <typename VectorType>
+VectorType toImplArray(const Vector<ScriptValue>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
 {
-    uint32_t length = 0;
-    if (value->IsArray()) {
-        length = v8::Local<v8::Array>::Cast(value)->Length();
-    } else if (!toV8Sequence(value, length, isolate, exceptionState)) {
-        if (!exceptionState.hadException())
-            exceptionState.throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex));
-        return HeapVector<T>();
-    }
-
-    if (length > WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(T)) {
-        exceptionState.throwTypeError("Array length exceeds supported limit.");
-        return HeapVector<T>();
-    }
-
-    HeapVector<T> result;
-    result.reserveInitialCapacity(length);
-    typedef NativeValueTraits<T> TraitsType;
-    v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
-    v8::TryCatch block;
-    for (uint32_t i = 0; i < length; ++i) {
-        v8::Local<v8::Value> element;
-        if (!v8Call(object->Get(isolate->GetCurrentContext(), i), element, block)) {
-            exceptionState.rethrowV8Exception(block.Exception());
-            return HeapVector<T>();
-        }
-        result.uncheckedAppend(TraitsType::nativeValue(isolate, element, exceptionState));
+    VectorType result;
+    typedef typename VectorType::ValueType ValueType;
+    typedef NativeValueTraits<ValueType> TraitsType;
+    result.reserveInitialCapacity(value.size());
+    for (unsigned i = 0; i < value.size(); ++i) {
+        result.uncheckedAppend(TraitsType::nativeValue(isolate, value[i].v8Value(), exceptionState));
         if (exceptionState.hadException())
-            return HeapVector<T>();
+            return VectorType();
     }
     return result;
 }
-
-template <typename T>
-Vector<T> toImplArray(const Vector<ScriptValue>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
-{
-    Vector<T> result;
-    result.reserveInitialCapacity(value.size());
-    for (unsigned i = 0; i < value.size(); ++i) {
-        result.uncheckedAppend(NativeValueTraits<T>::nativeValue(isolate, value[i].v8Value(), exceptionState));
-        if (exceptionState.hadException())
-            return Vector<T>();
-    }
-    return result;
-}
 
 template <typename T>
 Vector<T> toImplArguments(const v8::FunctionCallbackInfo<v8::Value>& info, int startIndex, ExceptionState& exceptionState)
 {
     Vector<T> result;
     typedef NativeValueTraits<T> TraitsType;
     int length = info.Length();
     if (startIndex < length) {
         result.reserveInitialCapacity(length - startIndex);
         for (int i = startIndex; i < length; ++i) {
@@ skipping 104 matching lines @@
     static inline ScriptValue nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
     {
         return ScriptValue(ScriptState::current(isolate), value);
     }
 };
 
 template <typename T>
 struct NativeValueTraits<Vector<T>> {
     static inline Vector<T> nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
     {
-        return toImplArray<T>(value, 0, isolate, exceptionState);
+        return toImplArray<Vector<T>>(value, 0, isolate, exceptionState);
     }
 };
 
 using JSONValuePtr = PassRefPtr<JSONValue>;
 template <>
 struct NativeValueTraits<JSONValuePtr> {
     CORE_EXPORT static JSONValuePtr nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&, int maxDepth = JSONValue::maxDepth);
 };
 
 CORE_EXPORT v8::Isolate* toIsolate(ExecutionContext*);
@@ skipping 123 matching lines @@
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate*, ExecutionContext*, v8::Local<v8::Function>);
 
 // Callback functions used by generated code.
 CORE_EXPORT void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::PropertyCallbackInfo<v8::Value>&);
 
 typedef void (*InstallTemplateFunction)(v8::Local<v8::FunctionTemplate>, v8::Isolate*);
 
 } // namespace blink
 
 #endif // V8Binding_h