Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125633002: [Telemetry] Enable import-error, bad-indentation, bad-whitespace lint check. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Enable import-error, bad-indentation, bad-whitespace lint check. BUG=475714 Committed: https://crrev.com/365d0800c0f214e1b9469e4342f7638fc3ec53f6 Cr-Commit-Position: refs/heads/master@{#328163}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M tools/telemetry/pylintrc View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_based_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_based_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/image_processing/histogram_unittest.py View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/image_processing/image_util_unittest.py View 4 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/internal/actions/mouse_click.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/trace_data_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
nednguyen
5 years, 7 months ago (2015-05-04 16:10:16 UTC) #3
dtu
lgtm
5 years, 7 months ago (2015-05-04 17:58:31 UTC) #4
aiolos (Not reviewing)
On 2015/05/04 17:58:31, dtu wrote: > lgtm lgtm
5 years, 7 months ago (2015-05-04 17:59:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125633002/20001
5 years, 7 months ago (2015-05-04 17:59:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-04 18:59:21 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 19:00:21 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/365d0800c0f214e1b9469e4342f7638fc3ec53f6
Cr-Commit-Position: refs/heads/master@{#328163}

Powered by Google App Engine
This is Rietveld 408576698