tools/telemetry/telemetry/util/cloud_storage_unittest.py - Issue 1125633002: [Telemetry] Enable import-error, bad-indentation, bad-whitespace lint check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/util/cloud_storage_unittest.py

Issue 1125633002: [Telemetry] Enable import-error, bad-indentation, bad-whitespace lint check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_set_unittest.py ('k') | tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/util/cloud_storage_unittest.py

diff --git a/tools/telemetry/telemetry/util/cloud_storage_unittest.py b/tools/telemetry/telemetry/util/cloud_storage_unittest.py

index 7e40f44b296c13040b24a30f28f91c5d080905b1..f598b67d27688d62f69fc7d698798b2ebc41c353 100644

--- a/tools/telemetry/telemetry/util/cloud_storage_unittest.py

+++ b/tools/telemetry/telemetry/util/cloud_storage_unittest.py

@@ -45,9 +45,9 @@ class CloudStorageUnitTest(unittest.TestCase):

cloud_storage.FindGsutil = orig_find_gs_util

def testRunCommandCredentialsError(self):

- strs = ['You are attempting to access protected data with no configured',

- 'Failure: No handler was ready to authenticate.']

- self._assertRunCommandRaisesError(strs, cloud_storage.CredentialsError)

+ strs = ['You are attempting to access protected data with no configured',

+ 'Failure: No handler was ready to authenticate.']

+ self._assertRunCommandRaisesError(strs, cloud_storage.CredentialsError)

def testRunCommandPermissionError(self):

strs = ['status=403', 'status 403', '403 Forbidden']

@@ -134,7 +134,7 @@ class CloudStorageUnitTest(unittest.TestCase):

'dir2':['2file.txt'], 'dir3':['3file1.sha1']}

stubs.os.path.dirs = ['real_dir_path']

def IncrementFilesUpdated(*_):

- IncrementFilesUpdated.files_updated +=1

+ IncrementFilesUpdated.files_updated += 1

IncrementFilesUpdated.files_updated = 0

orig_get_if_changed = cloud_storage.GetIfChanged

cloud_storage.GetIfChanged = IncrementFilesUpdated