Source/core/frame/UseCounter.cpp - Issue 1125573003: Update deprecation messages for powerful features on insecure origins

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 1125573003: Update deprecation messages for powerful features on insecure origins (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update -expected.txt Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt ('k') | Source/modules/device_orientation/DeviceMotionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/UseCounter.cpp

diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp

index 737af97e0aca74ab5ce71d5ca2c566920f2de4c6..f65d97c72d0341cb0f4d4422c09a0cce5c5e4e11 100644

--- a/Source/core/frame/UseCounter.cpp

+++ b/Source/core/frame/UseCounter.cpp

@@ -898,19 +898,13 @@ String UseCounter::deprecationMessage(Feature feature)

// Powerful features on insecure origins (https://goo.gl/rStTGz)

case GeolocationInsecureOrigin:

- return "Geolocation via getCurrentPosition() and watchPosition() will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

+ return "getCurrentPosition() and watchPosition() are deprecated on insecure origins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

case GetUserMediaInsecureOrigin:

- return "getUserMedia() will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

- case DeviceMotionInsecureOrigin:

- return "The 'devicemotion' event will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

- case DeviceOrientationInsecureOrigin:

- return "The 'deviceorientation' event will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

+ return "getUserMedia() is deprecated on insecure origins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

case FullscreenInsecureOrigin:

- return "requestFullscreen() will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

+ return "requestFullscreen() is deprecated on insecure origins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

// Features that aren't deprecated don't have a deprecation message.

default: