Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1125573003: Update deprecation messages for powerful features on insecure origins (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update -expected.txt Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 891
892 case AttrChildAccess: 892 case AttrChildAccess:
893 case AttrChildChange: 893 case AttrChildChange:
894 return "Attr child nodes are deprecated and will be removed in M45, arou nd August 2015. Please use 'Attr.value' instead."; 894 return "Attr child nodes are deprecated and will be removed in M45, arou nd August 2015. Please use 'Attr.value' instead.";
895 895
896 case CSSKeyframesRuleInsertRule: 896 case CSSKeyframesRuleInsertRule:
897 return "'CSSKeyframesRule.insertRule()' is deprecated and will be remove d in M45, around August 2015. Please use 'CSSKeyframesRule.appendRule()' instead ."; 897 return "'CSSKeyframesRule.insertRule()' is deprecated and will be remove d in M45, around August 2015. Please use 'CSSKeyframesRule.appendRule()' instead .";
898 898
899 // Powerful features on insecure origins (https://goo.gl/rStTGz) 899 // Powerful features on insecure origins (https://goo.gl/rStTGz)
900 case GeolocationInsecureOrigin: 900 case GeolocationInsecureOrigin:
901 return "Geolocation via getCurrentPosition() and watchPosition() will be deprecated over insecure origins in the future. You should consider switching y our application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details."; 901 return "getCurrentPosition() and watchPosition() are deprecated on insec ure origins, and support will be removed in the future. You should consider swit ching your application to a secure origin, such as HTTPS. See https://goo.gl/rSt TGz for more details.";
902 902
903 case GetUserMediaInsecureOrigin: 903 case GetUserMediaInsecureOrigin:
904 return "getUserMedia() will be deprecated over insecure origins in the f uture. You should consider switching your application to a secure origin, such a s HTTPS. See https://goo.gl/rStTGz for more details."; 904 return "getUserMedia() is deprecated on insecure origins, and support wi ll be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
905
906 case DeviceMotionInsecureOrigin:
907 return "The 'devicemotion' event will be deprecated over insecure origin s in the future. You should consider switching your application to a secure orig in, such as HTTPS. See https://goo.gl/rStTGz for more details.";
908
909 case DeviceOrientationInsecureOrigin:
910 return "The 'deviceorientation' event will be deprecated over insecure o rigins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
911 905
912 case FullscreenInsecureOrigin: 906 case FullscreenInsecureOrigin:
913 return "requestFullscreen() will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, s uch as HTTPS. See https://goo.gl/rStTGz for more details."; 907 return "requestFullscreen() is deprecated on insecure origins, and suppo rt will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details." ;
914 908
915 // Features that aren't deprecated don't have a deprecation message. 909 // Features that aren't deprecated don't have a deprecation message.
916 default: 910 default:
917 return String(); 911 return String();
918 } 912 }
919 } 913 }
920 914
921 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 915 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
922 { 916 {
923 ASSERT(feature >= firstCSSProperty); 917 ASSERT(feature >= firstCSSProperty);
(...skipping 28 matching lines...) Expand all
952 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 946 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
953 { 947 {
954 // FIXME: We may want to handle stylesheets that have multiple owners 948 // FIXME: We may want to handle stylesheets that have multiple owners
955 // http://crbug.com/242125 949 // http://crbug.com/242125
956 if (sheetContents && sheetContents->hasSingleOwnerNode()) 950 if (sheetContents && sheetContents->hasSingleOwnerNode())
957 return getFrom(sheetContents->singleOwnerDocument()); 951 return getFrom(sheetContents->singleOwnerDocument());
958 return 0; 952 return 0;
959 } 953 }
960 954
961 } // namespace blink 955 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698