Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125343005: Convert search page to Polymer 0.8. (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert search page to Polymer 0.8. BUG=485381 Committed: https://crrev.com/853946c597412bf03d3073702420359c0d131fc1 Cr-Commit-Position: refs/heads/master@{#329568}

Patch Set 1 #

Patch Set 2 : Fix events #

Total comments: 2

Patch Set 3 : Add css file #

Patch Set 4 : readonlys #

Total comments: 4

Patch Set 5 : test and add some fixes #

Patch Set 6 : css license #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -103 lines) Patch
A + chrome/browser/resources/settings/search_page/search_page.css View 1 2 3 4 5 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 2 3 4 1 chunk +17 lines, -23 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.js View 1 2 3 4 3 chunks +39 lines, -56 lines 0 comments Download
D chrome/browser/resources/settings/search_page/search_page_style.html View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-12 06:40:33 UTC) #2
michaelpg
https://codereview.chromium.org/1125343005/diff/20001/chrome/browser/resources/settings/search_page/search_page_style.html File chrome/browser/resources/settings/search_page/search_page_style.html (left): https://codereview.chromium.org/1125343005/diff/20001/chrome/browser/resources/settings/search_page/search_page_style.html#oldcode6 chrome/browser/resources/settings/search_page/search_page_style.html:6: -webkit-margin-start: 10px; no moar CSS file?
5 years, 7 months ago (2015-05-12 18:07:30 UTC) #3
Jeremy Klein
https://codereview.chromium.org/1125343005/diff/20001/chrome/browser/resources/settings/search_page/search_page_style.html File chrome/browser/resources/settings/search_page/search_page_style.html (left): https://codereview.chromium.org/1125343005/diff/20001/chrome/browser/resources/settings/search_page/search_page_style.html#oldcode6 chrome/browser/resources/settings/search_page/search_page_style.html:6: -webkit-margin-start: 10px; On 2015/05/12 18:07:30, michaelpg wrote: > no ...
5 years, 7 months ago (2015-05-12 18:33:20 UTC) #4
michaelpg
lgtm, assuming u fix the = https://codereview.chromium.org/1125343005/diff/60001/chrome/browser/resources/settings/search_page/search_page.html File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/1125343005/diff/60001/chrome/browser/resources/settings/search_page/search_page.html#newcode13 chrome/browser/resources/settings/search_page/search_page.html:13: <select id="searchEnginesMenu" on-change"defaultEngineGuidChanged_"> ...
5 years, 7 months ago (2015-05-12 19:00:50 UTC) #5
Jeremy Klein
https://codereview.chromium.org/1125343005/diff/60001/chrome/browser/resources/settings/search_page/search_page.html File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/1125343005/diff/60001/chrome/browser/resources/settings/search_page/search_page.html#newcode13 chrome/browser/resources/settings/search_page/search_page.html:13: <select id="searchEnginesMenu" on-change"defaultEngineGuidChanged_"> On 2015/05/12 19:00:50, michaelpg wrote: > ...
5 years, 7 months ago (2015-05-12 22:48:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125343005/120001
5 years, 7 months ago (2015-05-13 01:27:24 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-05-13 02:21:33 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 02:22:22 UTC) #11
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/853946c597412bf03d3073702420359c0d131fc1
Cr-Commit-Position: refs/heads/master@{#329568}

Powered by Google App Engine
This is Rietveld 408576698