chrome/browser/resources/settings/search_page/search_page.html - Issue 1125343005: Convert search page to Polymer 0.8.

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1125343005: Convert search page to Polymer 0.8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: readonlys Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.css ('k') | chrome/browser/resources/settings/search_page/search_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">	2 <link rel="import" href="chrome://resources/polymer/v0_8/paper-material/paper-ma terial.html">

3 <link rel="import" href="chrome://resources/polymer/core-style/core-style.html">

4 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

5 <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.ht ml">

6 <link rel="import" href="chrome://resources/cr_elements/cr_dropdown_menu/cr_drop down_menu.html">

7 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">	3 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">

8 <link rel="import" href="search_page_style.html">

9	4

10 <polymer-element name="cr-settings-search-page">	5 <dom-module id="cr-settings-search-page">

	6 <link rel="import" type="css" href="chrome://md-settings/settings_page/setting s_page.css">

	7 <link rel="import" type="css" href="search_page.css">

11 <template>	8 <template>

12 <link rel="stylesheet" href="chrome://md-settings/settings_page/settings_pag e.css">	9 <paper-material>

13 <core-style ref="searchPageStyle"></core-style>

14 <paper-shadow layout vertical cross-fade>

15 <p i18n-content="searchExplanation"></p>	10 <p i18n-content="searchExplanation"></p>

16	11

17 <div class="search-engines" layout horizontal center>	12 <div class="search-engines">

18 <cr-dropdown-menu class="search-engines-dropdown">	13 <select id="searchEnginesMenu" on-change"defaultEngineGuidChanged_">
	michaelpg 2015/05/12 19:00:50 missing = missing = Jeremy Klein 2015/05/12 22:48:44 Done. Show quoted text On 2015/05/12 19:00:50, michaelpg wrote: > missing = Done.
19 <core-menu id="searchEnginesMenu" class="menu" valueAttr="guid"	14 <template is="x-repeat" items="[[searchEngines]]">

20 selected="{{defaultEngineGuid}}">	15 <option value="[[item.guid]]">{{item.name}}</option>
	michaelpg 2015/05/12 19:00:50 I think {{item.name}} is effectively a one-way bin I think {{item.name}} is effectively a one-way binding, so I'd suggest using [[]] for it as well. Jeremy Klein 2015/05/12 22:48:44 Done. Show quoted text On 2015/05/12 19:00:50, michaelpg wrote: > I think {{item.name}} is effectively a one-way binding, so I'd suggest using > [[]] for it as well. Done.
21 <template repeat="{{engine in searchEngines}}">	16 </template>

22 <paper-item guid="{{engine.guid}}">{{engine.name}}</paper-item>	17 </select>

23 </template>

24 </core-menu>

25 </cr-dropdown-menu>

26	18

27 <cr-button class="manage-search-engines"	19 <cr-button class="manage-search-engines"

28 i18n-content="searchManageButtonLabel"	20 i18n-content="searchManageButtonLabel"

29 on-click="{{manageSearchEngines_}}" raised>	21 on-click="manageSearchEngines_" raised>

30 </cr-button>	22 </cr-button>

31 </div>	23 </div>

32 </paper-shadow>	24 </paper-material>

33 </template>	25 </template>

34 <script src="search_page.js"></script>	26 <script src="search_page.js"></script>

35 </polymer-element>	27 </dom-module>

OLD	NEW