Update Layer::GetTargetColor to account for animation state

Update Layer::GetTargetColor to account for animation state
Layer::GetTargetColor currently always checks the LayerAnimator for a target
color.

When the layer is not animating, the animator's defaults do not necessarily
reflect the current state of the layer. This change updates
Layer::GetTargetColor to return the current color if not animating.

TEST=LayerOwnerTest, RecreateLayerSolidColorWithChangedCCLayerHonorsTargets,
ran compositor_unittests, ash_unittests, views_unittests
BUG=chrome-os-partner:40118
Committed: https://crrev.com/31048b60684f840102adffa211f746ec4218abbd
Cr-Commit-Position: refs/heads/master@{#330679}

[jonross, 2015-05-19 16:09:53]

jonross@chromium.org changed reviewers:
+ danakj@chromium.org

[jonross, 2015-05-19 16:09:54]

Hi Dana,

I created a new review for my fix to LAYER_SOLID_COLOR having incorrect color
and opaqueness after a call to LayerOwner::RecreateLayer.

This review includes a unittest that reproduces the issue.

Could you provide a review?

Thanks.

[danakj, 2015-05-19 17:44:40]

Can you add a simple layer_unittest also that checks GetTargetColor returns the
right thing when animating vs not animating?

[jonross, 2015-05-19 20:53:52]

Added tests to layer_unittests, to confirm current/target value. Both when not
animating, and while animating. Also with the CCLayer being switched.

[danakj, 2015-05-19 21:56:25]

LGTM thanks!

https://codereview.chromium.org/1125283015/diff/20001/ui/compositor/layer_uni...
File ui/compositor/layer_unittest.cc (right):

https://codereview.chromium.org/1125283015/diff/20001/ui/compositor/layer_uni...
ui/compositor/layer_unittest.cc:1618:
ASSERT_FALSE(root->fills_bounds_opaquely());
EXPECT rather than ASSERT everywhere

[jonross, 2015-05-20 01:03:54]

https://codereview.chromium.org/1125283015/diff/20001/ui/compositor/layer_uni...
File ui/compositor/layer_unittest.cc (right):

https://codereview.chromium.org/1125283015/diff/20001/ui/compositor/layer_uni...
ui/compositor/layer_unittest.cc:1618:
ASSERT_FALSE(root->fills_bounds_opaquely());
On 2015/05/19 21:56:25, danakj wrote:
> EXPECT rather than ASSERT everywhere

Done.

[jonross, 2015-05-20 01:03:59]

The CQ bit was checked by jonross@chromium.org

[jonross, 2015-05-20 01:04:00]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1125283015/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-05-20 01:05:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125283015/40001

[commit-bot: I haz the power, 2015-05-20 02:09:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-20 02:10:29]

Patchset 3 (id:??) landed as
https://crrev.com/31048b60684f840102adffa211f746ec4218abbd
Cr-Commit-Position: refs/heads/master@{#330679}