Move renderFallbackContent() into FrameOwner interface.

Move renderFallbackContent() into FrameOwner interface.

This is needed to support fallback content for <object> frames that
might be rendered cross process.

BUG=483636
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195068

[dcheng, 2015-05-06 18:57:37]

dcheng@chromium.org changed reviewers:
+ japhet@chromium.org

[dcheng, 2015-05-06 18:57:38]

Unfortunately, I think we'll have to replicate the kind of element the frame
owner is (so RemoteBridgeFrameOwner can synchronously return true/false) in a
followup patch.

https://codereview.chromium.org/1125053002/diff/40001/Source/core/html/HTMLOb...
File Source/core/html/HTMLObjectElement.cpp (right):

https://codereview.chromium.org/1125053002/diff/40001/Source/core/html/HTMLOb...
Source/core/html/HTMLObjectElement.cpp:366: return false;
I moved this check because if it's not in a document, it doesn't really make
sense to do anything further here.

I could make it return true as well, but logically, I think it makes a little
more sense to return false?

[Nate Chapin, 2015-05-06 20:15:05]

I feel like there's got to be a way to avoid needing to propagate the bit for
whether this is an <object> or not. LGTM if you think that propagating the bit
is the easier path forward.

https://codereview.chromium.org/1125053002/diff/40001/Source/core/html/HTMLOb...
File Source/core/html/HTMLObjectElement.cpp (right):

https://codereview.chromium.org/1125053002/diff/40001/Source/core/html/HTMLOb...
Source/core/html/HTMLObjectElement.cpp:366: return false;
On 2015/05/06 18:57:38, dcheng wrote:
> I moved this check because if it's not in a document, it doesn't really make
> sense to do anything further here.
> 
> I could make it return true as well, but logically, I think it makes a little
> more sense to return false?

My guess is it's irrelevant. I'd think that any case that's checking the return
value can't happen if inDocument() is false, though I suspect some of the other
callers might need this early exit.

[dcheng, 2015-05-06 22:46:45]

Well, it seems like it doesn't actually matter if I cancel the load or not (see
PS4). So I simplified it and got rid of the bool return value. This also means
we don't need to propagate the state bit.

PTAL!

[Nate Chapin, 2015-05-07 18:01:07]

https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
File Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
Source/core/loader/DocumentLoader.cpp:462: if
(m_frame->owner()->renderFallbackContent()) {
This block looks empty? Is returning a bool actually necesssary?

[dcheng, 2015-05-07 18:02:12]

https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
File Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
Source/core/loader/DocumentLoader.cpp:462: if
(m_frame->owner()->renderFallbackContent()) {
On 2015/05/07 18:01:07, Nate Chapin wrote:
> This block looks empty? Is returning a bool actually necesssary?

I think this is already cleaned up in the latest PS =)

[Nate Chapin, 2015-05-07 18:07:02]

On 2015/05/07 18:02:12, dcheng wrote:
>
https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
> File Source/core/loader/DocumentLoader.cpp (right):
> 
>
https://codereview.chromium.org/1125053002/diff/60001/Source/core/loader/Docu...
> Source/core/loader/DocumentLoader.cpp:462: if
> (m_frame->owner()->renderFallbackContent()) {
> On 2015/05/07 18:01:07, Nate Chapin wrote:
> > This block looks empty? Is returning a bool actually necesssary?
> 
> I think this is already cleaned up in the latest PS =)

Derp, I really thought I had closed the older version. LGTM

[dcheng, 2015-05-07 18:12:01]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-05-07 18:12:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125053002/80001

[commit-bot: I haz the power, 2015-05-07 18:15:27]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195068