Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/web/RemoteBridgeFrameOwner.h

Issue 1125053002: Move renderFallbackContent() into FrameOwner interface. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Simplify Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/RemoteBridgeFrameOwner.h
diff --git a/Source/web/RemoteBridgeFrameOwner.h b/Source/web/RemoteBridgeFrameOwner.h
index 81a860229fd46353beb2faf8961a3ae3e8384769..a022f820f100afb064a97e947597d6924aae8410 100644
--- a/Source/web/RemoteBridgeFrameOwner.h
+++ b/Source/web/RemoteBridgeFrameOwner.h
@@ -15,7 +15,7 @@ namespace blink {
// 1. Allows the local frame's loader to retrieve sandbox flags associated with
// its owner element in another process.
// 2. Trigger a load event on its owner element once it finishes a load.
-class RemoteBridgeFrameOwner : public NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner {
+class RemoteBridgeFrameOwner final : public NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RemoteBridgeFrameOwner);
public:
static PassOwnPtrWillBeRawPtr<RemoteBridgeFrameOwner> create(PassRefPtrWillBeRawPtr<WebLocalFrameImpl> frame, SandboxFlags flags)
@@ -23,12 +23,12 @@ public:
return adoptPtrWillBeNoop(new RemoteBridgeFrameOwner(frame, flags));
}
- virtual bool isLocal() const override
+ bool isLocal() const override
{
return false;
}
- virtual SandboxFlags sandboxFlags() const override
+ SandboxFlags sandboxFlags() const override
{
return m_sandboxFlags;
}
@@ -43,7 +43,12 @@ public:
m_frame = frame;
}
- virtual void dispatchLoad() override;
+ void dispatchLoad() override;
+
+ void renderFallbackContent() override
+ {
+ // TODO(dcheng): Implement.
+ }
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698