Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1124973003: bluetooth: Add NetworkError for Bluetooth on Blink side (Closed)

Created:
5 years, 7 months ago by ortuno
Modified:
5 years, 7 months ago
Reviewers:
scheib
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Add NetworkError for Bluetooth on Blink side This error is meant to be returned when the connection to the device fails. This is the first of two patches to implement NetworkError: [1] This patch. [2] https://codereview.chromium.org/1118053003 BUG=484779 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/modules/bluetooth/WebBluetoothError.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ortuno
@scheib: Please review.
5 years, 7 months ago (2015-05-05 21:52:34 UTC) #2
scheib
LGTM
5 years, 7 months ago (2015-05-05 22:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124973003/1
5 years, 7 months ago (2015-05-06 17:08:52 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:00:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194991

Powered by Google App Engine
This is Rietveld 408576698