Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1118053003: bluetooth: Add NetworkError for Bluetooth on browser side (Closed)

Created:
5 years, 7 months ago by ortuno
Modified:
5 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-connect-gatt-implementation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add NetworkError for Bluetooth on browser side Return the NetworkError if the connectGATT fails. This is the second of two patches to implement NetworkError: [1] https://codereview.chromium.org/1124973003 [2] This patch. BUG=484779 Committed: https://crrev.com/71fd6178f81b1a40d201da5f8144354e5e92bd71 Cr-Commit-Position: refs/heads/master@{#329512}

Patch Set 1 #

Patch Set 2 : Merged with TOT #

Patch Set 3 : Remove from bluetooth_dispatcher_host so that we can commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/child/bluetooth/bluetooth_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/bluetooth/bluetooth_error.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
scheib
Please add a reference note to https://github.com/WebBluetoothChrome/web-bluetooth
5 years, 7 months ago (2015-05-05 22:34:14 UTC) #2
scheib
LGTM
5 years, 7 months ago (2015-05-05 22:38:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118053003/40001
5 years, 7 months ago (2015-05-12 21:24:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 22:25:14 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:26:02 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/71fd6178f81b1a40d201da5f8144354e5e92bd71
Cr-Commit-Position: refs/heads/master@{#329512}

Powered by Google App Engine
This is Rietveld 408576698