Whitespace change to test depot-tools presubmit on CQ.

Whitespace change to test depot-tools presubmit on CQ.

BUG=
TBR=iannucci@chromium.org

[luqui, 2015-05-04 22:26:15]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-05-04 22:26:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124803002/1

[commit-bot: I haz the power, 2015-05-04 22:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-04 22:29:39]

Presubmit check for 1124803002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Initialized empty Git repository in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/_rietveld/.git/
Updating origin
From https://chromium.googlesource.com/infra/infra
 * [new branch]      deployed   -> origin/deployed
 * [new branch]      master     -> origin/master
From https://chromium.googlesource.com/infra/infra
 * branch            master     -> FETCH_HEAD
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/git_rebase_update_test.py (12.72s) failed
.Switched to branch foobar.
Switched to branch sub_K.
Switched to branch old_branch.
Switched to branch empty_branch.
Switched to branch empty_branch2.
FSwitched to branch foobar.
.
======================================================================
FAIL: testRebaseUpdate (__main__.GitRebaseUpdateTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_rebase_update_test.py", line 207, in testRebaseUpdate
    'branch_L', 'old_branch', 'foobar'})
AssertionError: Items in the first set but not the second:
'origin/master)'

----------------------------------------------------------------------
Ran 3 tests in 12.534s

FAILED (failures=1)
Name                  Stmts   Miss  Cover   Missing
---------------------------------------------------
git_new_branch           28      0   100%   
git_rebase_update       144      0   100%   
git_rename_branch        29      0   100%   
git_reparent_branch      43      0   100%   
---------------------------------------------------
TOTAL                   244      0   100%   


tests/git_common_test.py (6.42s) failed
...x....F.....FF........uCannot foo with a dirty tree. You must commit locally
first.
Uncommitted files: (git diff-index --name-status HEAD)
A	test.file
.......
======================================================================
FAIL: testGetBranchTree (__main__.GitMutableStructuredTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 536, in testGetBranchTree
    self.assertEqual(skipped, {'master', 'root_X', 'branch_DOG', 'root_CAT'})
AssertionError: Items in the first set but not the second:
'78df7e3)'

======================================================================
FAIL: testTooManyBranches (__main__.GitMutableStructuredTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 464, in testTooManyBranches
    self.assertEqual(38, len(self.repo.run(list, self.gc.branches())))
AssertionError: 38 != 39

======================================================================
FAIL: testBranches (__main__.GitReadOnlyFunctionsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 235, in testBranches
    {'master', 'branch_D', 'root_A'})
AssertionError: Items in the first set but not the second:
'696a838)'

----------------------------------------------------------------------
Ran 32 tests in 6.202s

FAILED (failures=3, expected failures=1, unexpected successes=1)
Name         Stmts   Miss  Cover   Missing
------------------------------------------
git_common     388     19    95%   319, 683-706
FATAL: not at 100% coverage.


Presubmit checks took 177.1s to calculate.

[wychen, 2015-05-11 17:44:15]

Presubmit on CQ still fails now.

[Adrian Kuegel, 2015-05-12 10:00:22]

On 2015/05/11 17:44:15, wychen wrote:
> Presubmit on CQ still fails now.

I think this breakage might be caused by
https://codereview.chromium.org/1110403003
The git checkout of rietveld seems to interfere with the tests.

[Adrian Kuegel, 2015-05-12 10:09:01]

On 2015/05/12 10:00:22, Adrian Kuegel wrote:
> On 2015/05/11 17:44:15, wychen wrote:
> > Presubmit on CQ still fails now.
> 
> I think this breakage might be caused by
> https://codereview.chromium.org/1110403003
> The git checkout of rietveld seems to interfere with the tests.

Of course this is just a guess, I based this on the fact that before that CL,
presubmits still seemed to pass, while they now seem to fail 100% of the time.

[Adrian Kuegel, 2015-05-12 10:27:17]

On 2015/05/12 10:09:01, Adrian Kuegel wrote:
> On 2015/05/12 10:00:22, Adrian Kuegel wrote:
> > On 2015/05/11 17:44:15, wychen wrote:
> > > Presubmit on CQ still fails now.
> > 
> > I think this breakage might be caused by
> > https://codereview.chromium.org/1110403003
> > The git checkout of rietveld seems to interfere with the tests.
> 
> Of course this is just a guess, I based this on the fact that before that CL,
> presubmits still seemed to pass, while they now seem to fail 100% of the time.

Ok, something else I noticed: on my local machine, the test passes, and I have
git version 2.2.0.rc0.207.ga3a616c
CQ machine seems to have git version 2.4.0.

[Adrian Kuegel, 2015-05-12 11:08:10]

On 2015/05/12 10:27:17, Adrian Kuegel wrote:
> On 2015/05/12 10:09:01, Adrian Kuegel wrote:
> > On 2015/05/12 10:00:22, Adrian Kuegel wrote:
> > > On 2015/05/11 17:44:15, wychen wrote:
> > > > Presubmit on CQ still fails now.
> > > 
> > > I think this breakage might be caused by
> > > https://codereview.chromium.org/1110403003
> > > The git checkout of rietveld seems to interfere with the tests.
> > 
> > Of course this is just a guess, I based this on the fact that before that
CL,
> > presubmits still seemed to pass, while they now seem to fail 100% of the
time.
> 
> Ok, something else I noticed: on my local machine, the test passes, and I have
> git version 2.2.0.rc0.207.ga3a616c
> CQ machine seems to have git version 2.4.0.

It is now more likely this is caused by the different git version. I filed
https://code.google.com/p/chromium/issues/detail?id=487172 for this.