Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1110403003: Change depot_tools presubmit to use infra rietveld from head. Also disable newly added backends by … (Closed)

Created:
5 years, 7 months ago by estaab
Modified:
5 years, 7 months ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Change depot_tools presubmit to use infra rietveld from head. Also disable newly added backends by specifying app.yaml explicitly. BUG=481568 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M testing_support/local_rietveld.py View 4 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
estaab
I'm open to other approaches, but I see this as a short-term fix until we ...
5 years, 7 months ago (2015-04-30 02:01:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110403003/1
5 years, 7 months ago (2015-04-30 02:02:01 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-30 02:02:03 UTC) #6
pgervais
On 2015/04/30 02:02:03, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 7 months ago (2015-04-30 16:36:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110403003/1
5 years, 7 months ago (2015-04-30 20:18:37 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 20:22:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295099

Powered by Google App Engine
This is Rietveld 408576698