Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124733004: Move DrawInfo out from GrDrawTarget and rename to GrVertices. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move DrawInfo out from GrDrawTarget and rename to GrVertices. Committed: https://skia.googlesource.com/skia/+/cb8979d088a66ebaf41f10ba6f5c830615aa0e03

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : comment changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -256 lines) Patch
M gm/beziereffects.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrBatch.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/GrBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBatchTarget.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrBatchTarget.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 5 chunks +22 lines, -21 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 4 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -146 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M src/gpu/GrGpu.h View 4 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +20 lines, -2 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 2 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/GrVertices.h View 1 2 1 chunk +161 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 7 months ago (2015-05-05 16:44:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124733004/40001
5 years, 7 months ago (2015-05-05 16:45:20 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-05 16:45:22 UTC) #5
joshualitt
On 2015/05/05 16:44:56, bsalomon wrote: lgtm
5 years, 7 months ago (2015-05-05 16:46:51 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 16:51:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cb8979d088a66ebaf41f10ba6f5c830615aa0e03

Powered by Google App Engine
This is Rietveld 408576698