Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1124653004: GrowArrayElementsStub must save caller doubles for double ElementsKind. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
danno, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GrowArrayElementsStub must save caller doubles for double ElementsKind. BUG= R=danno@chromium.org Committed: https://crrev.com/9d0d7ec73057c9094e471db84e39cf7b36252674 Cr-Commit-Position: refs/heads/master@{#28232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Danno, Here is a small but important bugfix to my CL of last week, ...
5 years, 7 months ago (2015-05-05 13:25:45 UTC) #1
Toon Verwaest
lgtm
5 years, 7 months ago (2015-05-05 14:37:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124653004/1
5 years, 7 months ago (2015-05-05 14:42:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 14:44:07 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 14:44:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d0d7ec73057c9094e471db84e39cf7b36252674
Cr-Commit-Position: refs/heads/master@{#28232}

Powered by Google App Engine
This is Rietveld 408576698