Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 1124653004: GrowArrayElementsStub must save caller doubles for double ElementsKind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index d346e95af20411b48aadef4fedca2a977f531719..d841ea05cb76abe0e1d9040fcd76847271d64895 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -578,11 +578,15 @@ Handle<Code> StoreScriptContextFieldStub::GenerateCode() {
template <>
HValue* CodeStubGraphBuilder<GrowArrayElementsStub>::BuildCodeStub() {
+ ElementsKind kind = casted_stub()->elements_kind();
+ if (IsFastDoubleElementsKind(kind)) {
+ info()->MarkAsSavesCallerDoubles();
+ }
+
HValue* object = GetParameter(GrowArrayElementsDescriptor::kObjectIndex);
HValue* key = GetParameter(GrowArrayElementsDescriptor::kKeyIndex);
HValue* current_capacity =
GetParameter(GrowArrayElementsDescriptor::kCapacityIndex);
- ElementsKind kind = casted_stub()->elements_kind();
HValue* elements = AddLoadElements(object);
HValue* length =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698