Issue 1124633003: Revert of Start on simplifying generateGeometry() overrides

Issue 1124633003: Revert of Start on simplifying generateGeometry() overrides (Closed)

Created:
5 years, 7 months ago by bsalomon

Modified:
5 years, 7 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org, robertphillips

Base URL:
https://skia.googlesource.com/skia.git@ibcache

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Start on simplifying generateGeometry() overrides (patchset #10 id:160001 of https://codereview.chromium.org/1122673002/) Reason for revert: Breaking bots Original issue's description: > Start on simplifying generateGeometry() overrides > > Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8415abe44cf205ac214b7793c076fd8c13272240

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+759 lines, -458 lines)			Patch
M	gm/beziereffects.cpp	View	4 chunks	+57 lines, -13 lines	0 comments	Download
M	gm/convexpolyeffect.cpp	View	2 chunks	+30 lines, -6 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	src/gpu/GrAADistanceFieldPathRenderer.cpp	View	9 chunks	+72 lines, -54 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	3 chunks	+46 lines, -20 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	5 chunks	+76 lines, -20 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	9 chunks	+40 lines, -31 lines	0 comments	Download
M	src/gpu/GrBatch.h	View	2 chunks	+1 line, -43 lines	0 comments	Download
M	src/gpu/GrBatch.cpp	View	2 chunks	+0 lines, -42 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	3 chunks	+20 lines, -7 lines	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View	2 chunks	+43 lines, -107 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	3 chunks	+54 lines, -20 lines	0 comments	Download
M	src/gpu/GrOvalRenderer.cpp	View	13 chunks	+233 lines, -63 lines	0 comments	Download
M	src/gpu/GrTessellatingPathRenderer.cpp	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrDashingEffect.cpp	View	4 chunks	+50 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Start on simplifying generateGeometry() overrides

5 years, 7 months ago (2015-05-04 18:41:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124633003/1

5 years, 7 months ago (2015-05-04 18:41:21 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 18:41:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8415abe44cf205ac214b7793c076fd8c13272240