Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 112463002: Add check to run-bindings-tests for excess files (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, lgombos, kouhei (in TOK)
Visibility:
Public.

Description

Add check to run-bindings-tests for excess files Renaming or deleting IDL test cases can leave cruft, b/c we don't check that all files are actually generated by run-bindings-tests. For example, this required the following recent CL: Remove V8TestSerializedScriptValueInterface.cpp https://codereview.chromium.org/107093008 This adds a check to avoid this in future. Also some associated refactoring of run-bindings-tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M Tools/Scripts/webkitpy/bindings/main.py View 5 chunks +32 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-11 04:53:54 UTC) #1
haraken
LGTM
7 years ago (2013-12-11 05:04:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/112463002/1
7 years ago (2013-12-11 05:09:43 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-11 06:18:18 UTC) #4
Message was sent while issue was closed.
Change committed as 163679

Powered by Google App Engine
This is Rietveld 408576698