Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 107093008: Remove V8TestSerializedScriptValueInterface.cpp (Closed)

Created:
7 years ago by lgombos
Modified:
7 years ago
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove V8TestSerializedScriptValueInterface.cpp. The file has been removed as part of r163135 but got merge back again in r163178 by accident. Lets try to remove it again for good this time. BUG=270033 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -336 lines) Patch
D Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 chunk +0 lines, -336 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
Cleanup.. I noticed that this test result does not get updated by --reset-test-results. Sure enough ...
7 years ago (2013-12-10 02:20:43 UTC) #1
haraken
LGTM
7 years ago (2013-12-10 02:23:01 UTC) #2
Nils Barth (inactive)
Thanks Laszlo!
7 years ago (2013-12-10 02:27:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/107093008/1
7 years ago (2013-12-10 02:28:08 UTC) #4
commit-bot: I haz the power
Change committed as 163484
7 years ago (2013-12-10 02:28:50 UTC) #5
Nils Barth (inactive)
7 years ago (2013-12-11 04:54:41 UTC) #6
Message was sent while issue was closed.
On 2013/12/10 02:20:43, lgombos wrote:
> Cleanup.. I noticed that this test result does not get updated by
> --reset-test-results. Sure enough this is a stale test result with no input
file
> any more.

BTW, posted CL to prevent this in future:
Add check to run-bindings-tests for excess files
https://codereview.chromium.org/112463002/

Powered by Google App Engine
This is Rietveld 408576698