Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1124553007: Be sure to abort incremental GC when trying to reserve space (Closed)

Created:
5 years, 7 months ago by Erik Corry Chromium.org
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Be sure to abort incremental GC when trying to reserve space R=hpayer@chromium.org BUG= Committed: https://crrev.com/49fdc5323496a6512631b0f43402330d61b95a31 Cr-Commit-Position: refs/heads/master@{#28233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Erik Corry Chromium.org
5 years, 7 months ago (2015-05-05 14:27:16 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-05 14:28:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124553007/1
5 years, 7 months ago (2015-05-05 14:33:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 14:57:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49fdc5323496a6512631b0f43402330d61b95a31 Cr-Commit-Position: refs/heads/master@{#28233}
5 years, 7 months ago (2015-05-05 14:57:40 UTC) #6
Erik Corry
5 years, 7 months ago (2015-05-10 11:59:59 UTC) #7
Message was sent while issue was closed.
This is part of canary 2395

Powered by Google App Engine
This is Rietveld 408576698