src/heap/heap.cc - Issue 1124553007: Be sure to abort incremental GC when trying to reserve space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1124553007: Be sure to abort incremental GC when trying to reserve space (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index a1e2e1671e42c0e7072e05fa194688400a41e296..e5095c8336c9f7d75eb476af501ec55ecbf668d4 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -1027,7 +1027,7 @@ bool Heap::ReserveSpace(Reservation* reservations) {

} else {

if (counter > 1) {

CollectAllGarbage(

- kReduceMemoryFootprintMask,

+ kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask,

"failed to reserve space in paged or large "

"object space, trying to reduce memory footprint");

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »