Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1124523003: Revert of Enable BeginFrame scheduling on aura (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable BeginFrame scheduling on aura (patchset #15 id:270001 of https://codereview.chromium.org/1016033006/) Reason for revert: Making Autofill interactive tests incredibly flaky again: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1) http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/ Original issue's description: > Enable BeginFrame scheduling on aura > > This cl is last partial cl from https://codereview.chromium.org/775143003/ > for easy review. > Until now, BeginFrame is initiated by each renderer process. > With this cl, BeginFrame is scheduled from parent(browser) cc scheduler > to child(renderer) cc scheduler. > For more detailed information, please see this (http://goo.gl/D1Qxrr) > > Also, --enable-begin-frame-scheduling is no longer needed because all platform except Mac > uses it as a default. > > R=brianderson@chromium.org, danakj@chromium.org, mithro@mithis.com > BUG=372086 > > Committed: https://crrev.com/17dd2f109f3155ebf183627b63df25f97f34b67f > Cr-Commit-Position: refs/heads/master@{#322622} > > Committed: https://crrev.com/62a759e582743bca13f27d1ce5db3dc2fe66fbb6 > Cr-Commit-Position: refs/heads/master@{#328170} TBR=brianderson@chromium.org,danakj@chromium.org,mithro@mithis.com,sievers@chromium.org,oshima@chromium.org,boliu@chromium.org,simonhong@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=372086 Committed: https://crrev.com/e627c5239eed0c99cbb7c9973d9241c125aaaed3 Cr-Commit-Position: refs/heads/master@{#328267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -83 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 3 chunks +14 lines, -3 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.h View 6 chunks +14 lines, -2 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.h View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/begin_frame_observer_proxy.h View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/renderer_host/begin_frame_observer_proxy.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 5 chunks +3 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 7 chunks +7 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +6 lines, -8 lines 0 comments Download
M ui/compositor/compositor.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/compositor/compositor_vsync_manager.h View 1 chunk +65 lines, -0 lines 0 comments Download
A ui/compositor/compositor_vsync_manager.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Enable BeginFrame scheduling on aura
5 years, 7 months ago (2015-05-05 03:24:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124523003/1
5 years, 7 months ago (2015-05-05 03:24:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 03:26:01 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 03:26:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e627c5239eed0c99cbb7c9973d9241c125aaaed3
Cr-Commit-Position: refs/heads/master@{#328267}

Powered by Google App Engine
This is Rietveld 408576698