src/x64/macro-assembler-x64.cc - Issue 1124443004: New hydrogen instruction to reduce cost of growing an array on keyed stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 1124443004: New hydrogen instruction to reduce cost of growing an array on keyed stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: ia32 and x64 done. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 0e70826df2297d003f28c3de27577394fd9b57a2..82e73a5a9c048bf73bb0a5451507ff6d7ee7895f 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -925,7 +925,11 @@ Register MacroAssembler::GetSmiConstant(Smi* source) {

void MacroAssembler::LoadSmiConstant(Register dst, Smi* source) {

Benedikt Meurer 2015/05/08 10:46:31 Hm, we tried that before, see https://codereview.c

- Move(dst, source, Assembler::RelocInfoNone());

+ if (source->value() == 0) {

+ xorl(dst, dst);

+ } else {

+ Move(dst, source, Assembler::RelocInfoNone());

+ }

}

« no previous file with comments | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »