Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1059543004: Revert of [x64] Use xorl to materialize smi zero. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [x64] Use xorl to materialize smi zero. (patchset #1 id:1 of https://codereview.chromium.org/1085153002/) Reason for revert: Seems to cause performance regressions. Original issue's description: > [x64] Use xorl to materialize smi zero. > > Before we always loaded smi zero via a movabs with a 64-bit immediate, > which is pretty expensive compared to the xorl. > > R=jarin@chromium.org > > Committed: https://crrev.com/f236777bfe6e080ff1ead6baf847cc9b6bb4f9cb > Cr-Commit-Position: refs/heads/master@{#27829} TBR=jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:477592 LOG=n Committed: https://crrev.com/c66a2f7b468cae9ef1972f0001bf4b8efef60f98 Cr-Commit-Position: refs/heads/master@{#27867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/x64/macro-assembler-x64.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [x64] Use xorl to materialize smi zero.
5 years, 8 months ago (2015-04-16 08:29:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059543004/1
5 years, 8 months ago (2015-04-16 08:30:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 08:31:31 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 08:31:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c66a2f7b468cae9ef1972f0001bf4b8efef60f98
Cr-Commit-Position: refs/heads/master@{#27867}

Powered by Google App Engine
This is Rietveld 408576698