Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2424)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 1124383004: Removes the new-avatar-menu flags, enabling the feature for all users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index a80c7580269c2bda4d415bcf53fdbd1e101d70e7..45acc1e72a8aee33e5bdfb3ab7f4ab877ef05268 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -173,44 +173,6 @@ TEST_F(BrowserCommandControllerTest, AppFullScreen) {
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
}
-TEST_F(BrowserCommandControllerTest, OldAvatarMenuEnabledForOneOrMoreProfiles) {
- if (!profiles::IsMultipleProfilesEnabled())
- return;
-
- // The command line is reset at the end of every test by the test suite.
- switches::DisableNewAvatarMenuForTesting(
- base::CommandLine::ForCurrentProcess());
- ASSERT_FALSE(switches::IsNewAvatarMenu());
-
- TestingProfileManager testing_profile_manager(
- TestingBrowserProcess::GetGlobal());
- ASSERT_TRUE(testing_profile_manager.SetUp());
- ProfileManager* profile_manager = testing_profile_manager.profile_manager();
-
- chrome::BrowserCommandController command_controller(browser());
- const CommandUpdater* command_updater = command_controller.command_updater();
-
- bool enabled = true;
-#if defined(OS_CHROMEOS)
- // Chrome OS uses system tray menu to handle multi-profiles.
- enabled = false;
-#endif
-
- testing_profile_manager.CreateTestingProfile("p1");
- ASSERT_EQ(1U, profile_manager->GetNumberOfProfiles());
- EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
-
- testing_profile_manager.CreateTestingProfile("p2");
- ASSERT_EQ(2U, profile_manager->GetNumberOfProfiles());
- EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
-
- testing_profile_manager.DeleteTestingProfile("p1");
- ASSERT_EQ(1U, profile_manager->GetNumberOfProfiles());
- EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
-
- testing_profile_manager.DeleteTestingProfile("p2");
-}
-
TEST_F(BrowserCommandControllerTest, NewAvatarMenuEnabledWhenOnlyOneProfile) {
if (!profiles::IsMultipleProfilesEnabled())
return;

Powered by Google App Engine
This is Rietveld 408576698