chrome/browser/profiles/profile_list_desktop_unittest.cc - Issue 1124383004: Removes the new-avatar-menu flags, enabling the feature for all users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_list_desktop_unittest.cc

Issue 1124383004: Removes the new-avatar-menu flags, enabling the feature for all users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_info_cache_unittest.cc ('K') | « chrome/browser/profiles/profile_info_cache_unittest.cc ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_list_desktop_unittest.cc

diff --git a/chrome/browser/profiles/profile_list_desktop_unittest.cc b/chrome/browser/profiles/profile_list_desktop_unittest.cc

index 4f86a9f29cd71cc1c34fc2c2730f4eed9ea62fbd..0192aa144b51d8eb2e28aad0793dcfb3e3bed2b3 100644

--- a/chrome/browser/profiles/profile_list_desktop_unittest.cc

+++ b/chrome/browser/profiles/profile_list_desktop_unittest.cc

@@ -282,24 +282,6 @@ TEST_F(ProfileListDesktopTest, ShowAvatarMenuInTrial) {

#endif

}

-TEST_F(ProfileListDesktopTest, DontShowOldAvatarMenuForSingleProfile) {

- switches::DisableNewAvatarMenuForTesting(

- base::CommandLine::ForCurrentProcess());

- manager()->CreateTestingProfile("Test 1");

- EXPECT_FALSE(AvatarMenu::ShouldShowAvatarMenu());

- // If multiprofile mode is enabled, there are no other cases when we wouldn't

- // show the menu.

- if (profiles::IsMultipleProfilesEnabled())

- return;

- manager()->CreateTestingProfile("Test 2");

- EXPECT_FALSE(AvatarMenu::ShouldShowAvatarMenu());

TEST_F(ProfileListDesktopTest, AlwaysShowNewAvatarMenu) {

// If multiprofile mode is not enabled then the menu is never shown.

if (!profiles::IsMultipleProfilesEnabled())