Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124223012: Change JSONReader::ReadToValue to return a scoped_ptr (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, native-client-reviews_googlegroups.com, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change JSONReader::ReadToValue to return a scoped_ptr BUG=none Committed: https://crrev.com/69505deccedb458e39a3593888e50627467870fb Cr-Commit-Position: refs/heads/master@{#330823}

Patch Set 1 #

Patch Set 2 : chromedriver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -80 lines) Patch
M base/json/json_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/json/json_reader_unittest.cc View 12 chunks +58 lines, -58 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_device.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/network_conditions.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 7 months ago (2015-05-18 22:27:17 UTC) #2
brettw
lgtm
5 years, 7 months ago (2015-05-20 20:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124223012/20001
5 years, 7 months ago (2015-05-20 20:57:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 22:47:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 22:48:05 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/69505deccedb458e39a3593888e50627467870fb
Cr-Commit-Position: refs/heads/master@{#330823}

Powered by Google App Engine
This is Rietveld 408576698