Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/test/chromedriver/chrome/mobile_device.cc

Issue 1124223012: Change JSONReader::ReadToValue to return a scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: chromedriver Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/mobile_device.cc
diff --git a/chrome/test/chromedriver/chrome/mobile_device.cc b/chrome/test/chromedriver/chrome/mobile_device.cc
index 683dd6c9b55ec73cb1339a3fb0fa0ca67a3ead69..26a8e75a34a50c62f28c05ed72697d7bc3cd602b 100644
--- a/chrome/test/chromedriver/chrome/mobile_device.cc
+++ b/chrome/test/chromedriver/chrome/mobile_device.cc
@@ -16,8 +16,8 @@ MobileDevice::~MobileDevice() {}
Status FindMobileDevice(std::string device_name,
scoped_ptr<MobileDevice>* mobile_device) {
base::JSONReader json_reader(base::JSON_ALLOW_TRAILING_COMMAS);
- scoped_ptr<base::Value> devices_value;
- devices_value.reset(json_reader.ReadToValue(kMobileDevices));
+ scoped_ptr<base::Value> devices_value =
+ json_reader.ReadToValue(kMobileDevices);
if (!devices_value.get())
return Status(kUnknownError,
"could not parse mobile device list because " +
« no previous file with comments | « chrome/browser/local_discovery/privet_url_fetcher.cc ('k') | chrome/test/chromedriver/chrome/network_conditions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698