ui/views/view.cc - Issue 1124223010: ui: Eliminate allocating gfx::Canvas on the heap for every view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.cc

Issue 1124223010: ui: Eliminate allocating gfx::Canvas on the heap for every view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: canvasstack: addTODO Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 6964cbf2f6dfc78a9d1600c4f1297f861708691a..6890603cbd4e29ef9a24f4f3ad318f2e8e9eba4e 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -806,6 +806,7 @@ void View::Paint(const ui::PaintContext& parent_context) {

if (is_invalidated || !paint_cache_.UseCache(context)) {

ui::PaintRecorder recorder(context, &paint_cache_);

gfx::Canvas* canvas = recorder.canvas();

+ // TODO(danakj): This is not needed with impl-side/slimming paint.

gfx::ScopedCanvas scoped_canvas(canvas);

// If the View we are about to paint requested the canvas to be flipped, we

« no previous file with comments | « ui/native_theme/common_theme.cc ('k') | no next file » | no next file with comments »