ui/native_theme/common_theme.cc - Issue 1124223010: ui: Eliminate allocating gfx::Canvas on the heap for every view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/common_theme.cc

Issue 1124223010: ui: Eliminate allocating gfx::Canvas on the heap for every view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: canvasstack: addTODO Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/native_theme/common_theme.cc

diff --git a/ui/native_theme/common_theme.cc b/ui/native_theme/common_theme.cc

index 2b7f84485d4ff886ee40551a399c8d02b6bbd0d5..80f3452d76d822e45f668cc4e78bb3297c71ad49 100644

--- a/ui/native_theme/common_theme.cc

+++ b/ui/native_theme/common_theme.cc

@@ -221,8 +221,7 @@ scoped_ptr<gfx::Canvas> CommonThemeCreateCanvas(SkCanvas* sk_canvas) {

// scale factor from canvas scale.

SkMatrix m = sk_canvas->getTotalMatrix();

float device_scale = static_cast<float>(SkScalarAbs(m.getScaleX()));

- return make_scoped_ptr(

- gfx::Canvas::CreateCanvasWithoutScaling(sk_canvas, device_scale));

+ return make_scoped_ptr(new gfx::Canvas(sk_canvas, device_scale));

}

} // namespace ui

« no previous file with comments | « ui/gfx/render_text_unittest.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »